added legal page #291
added legal page #291
Conversation
|
just needs a link for "here" in "You can learn more about this experiment and its data collection here." cc @johngruen |
|
@dannycoates Re: #260 (comment)
I think the Test Pilot url in question is https://testpilot.firefox.com/experiments/send, per the "Learn more" link in /views/index.handlebars:6. |
| <a href="https://testpilot.firefox.com/privacy" data-l10n-id="footerLinkPrivacy"></a> | ||
| <a href="https://testpilot.firefox.com/terms" data-l10n-id="footerLinkTerms"></a> | ||
| <a href="/legal" data-l10n-id="footerLinkPrivacy"></a> | ||
| <a href="/legal" data-l10n-id="footerLinkTerms"></a> |
There was a problem hiding this comment.
Do we need two separate links that go to the same URL? or do we want some combined "Privacy & Terms" link?
There was a problem hiding this comment.
Whatever gets it shipped is fine w/ legal. Already a patch for this, so this works for me. :)
|
That "here" link looks right to me also. Thanks! |
|
/cc @flodolo |
|
Looks good to me to. More important, we need to port this in #269 |
fixes #260