Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Remove duplicate entities in localized FTL files #340

Merged
merged 1 commit into from Jul 27, 2017
Merged

Remove duplicate entities in localized FTL files #340

merged 1 commit into from Jul 27, 2017

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Jul 27, 2017

Removing trailing spaces is irrelevant in this context (they should have one)

@flodolo flodolo requested a review from pdehaan July 27, 2017 16:58
pdehaan
pdehaan approved these changes Jul 27, 2017
View reviewed changes
Copy link
Collaborator

@pdehaan pdehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ignored the whitespace tweaks w/ #340 but looks 💯!

👍 R+

@flodolo
Copy link
Collaborator Author

flodolo commented Jul 27, 2017

I see unrelated linter fails there were fixed in a later commit, merging without doing a rebase and another run.

@flodolo flodolo merged commit c9e914f into mozilla:master Jul 27, 2017
@flodolo flodolo deleted the fix_dupes branch July 27, 2017 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pdehaan pdehaan pdehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flodolo @pdehaan