Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Centre logo #571

Merged
merged 1 commit into from Oct 4, 2017
Merged

Centre logo #571

merged 1 commit into from Oct 4, 2017

Conversation

ehuggett
Copy link
Contributor

Related to #558

Centre the Send logo within the image

@ericawright
Copy link
Contributor

Can you explain a bit more what has changed in this? I read through the bug, but I don't fully understand what was decided upon

@ehuggett
Copy link
Contributor Author

ehuggett commented Oct 3, 2017

Sure, thanks for looking at this (its just a nit for the current usage of the logo, a couple of pixels or so off!)

The only addition should be transform="translate(-0.231,0.11948695) (its all on one line, so the github diff is not very useful).

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/transform
https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Basic_Transformations#Translation (has a better example for translate)

I believe this results in 0.231 being subtracted from all of the X coordinates and 0.11948695 added to all of the Y coordinates that describe the shape of the send logo within the 30 by 27 grid used. (This Moves it to the left and down slightly, Centring it more precisely than it was before)

The difference this makes can be seen at higher resolutions such as the images in this comment, there are no visual differences at lower resolutions (they seem to be pixel for pixel identical at 30x27, as best as I can tell with GIMP)

The transform/translate could be removed by rewriting all of the coordinates to their new values, but I didn't manage to do this at the time with Inkscape. I don't think it was deemed necessary, but if you want I can have a look into doing this

@ericawright
Copy link
Contributor

Thank you for explaining. I can't really detect the difference myself, but it's been approved by Sevaan and it hasn't broken anything, so it's good by me 👍

@ericawright ericawright merged commit 1eb000f into mozilla:master Oct 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants