This repository has been archived by the owner on May 22, 2021. It is now read-only.
Change Favicon in to look better in a variety of cases #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycoates
approved these changes
Oct 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following these guidelines and #558, here are a whole bunch of new icons.
Resulting in a better image on activity stream:
Unfortunately, I removed size 57x57 and size 76x76 since Firefox was choosing them and the result was (oddly) blurry. Since these sizes are used in fairly rare cases I decided it wasn't a big deal to remove them.
Has been tested on Chrome and Firefox on Mac. Would greatly appreciate if folks who have access to other hardware would look on that as well. Specifically Android, since that was what the original issue was opened for.
Fixes #558.