Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

big refactor #737

Merged
merged 1 commit into from Jan 30, 2018
Merged

big refactor #737

merged 1 commit into from Jan 30, 2018

Conversation

dannycoates
Copy link
Contributor

fixes #710 (api.js)
fixes #716 (api.js)
fixes #724 (misc refactoring)
fixes #688 (authKey is stored instead of plaintext password)
fixes #538

Copy link
Collaborator

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should use Intl for the two timer strings, but those are not actual dates…

Strings wise it looks good.

javascriptRequired = Firefox Send requires JavaScript
whyJavascript = Why does Firefox Send require JavaScript?
enableJavascript = Please enable JavaScript and try again.
//A short representation of a countdown timer containing the number of hours and minutes remaining as digits, example "13h 47m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after //

enableJavascript = Please enable JavaScript and try again.
//A short representation of a countdown timer containing the number of hours and minutes remaining as digits, example "13h 47m"
expiresHoursMinutes = { $hours }h { $minutes }m
//A short representation of a countdown timer containing the number of minutes remaining as digits, example "56m"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, space after //

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants