Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drain compositor_chan on shutdown, causes deadlocks on constellation
Constellation blocks on SetId by sending a Port through the compositor channel and waits for a response. If the compositor is in the process of shutting down, it will not look in the queue again. The compositor requires the constellation to be shut down first, so it sends a message to shut down and blocks until the constellation finishes, deadlocking. Only very short lived executions would've been likely to see this deadlock.
- Loading branch information
183c387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at dhedlund@183c387
183c387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging dhedlund/servo/constellation_deadlock = 183c387 into auto
183c387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dhedlund/servo/constellation_deadlock = 183c387 merged ok, testing candidate = b81749b
183c387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/722
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/677
183c387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b81749b