Fix a mistake in the redirect fetch code

The spec says to ignore both HEAD and GET in step 11
servo · May 5, 2020 · 2b28042 · 2b28042
1 parent aa43ce8
commit 2b28042
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/components/net/http_loader.rs b/components/net/http_loader.rs
@@ -804,7 +804,9 @@ pub fn http_redirect_fetch(
         .map_or(false, |(code, _)| {
             ((*code == StatusCode::MOVED_PERMANENTLY || *code == StatusCode::FOUND) &&
                 request.method == Method::POST) ||
-                (*code == StatusCode::SEE_OTHER && request.method != Method::HEAD)
+                (*code == StatusCode::SEE_OTHER &&
+                    request.method != Method::HEAD &&
+                    request.method != Method::GET)
         })
     {
         // Step 11.1

diff --git a/tests/wpt/metadata/fetch/api/redirect/redirect-method.any.js.ini b/tests/wpt/metadata/fetch/api/redirect/redirect-method.any.js.ini
@@ -1,7 +1,4 @@
 [redirect-method.any.worker.html]
-  [Redirect 303 with GET]
-    expected: FAIL
-
   [Redirect 307 with POST (string body)]
     expected: FAIL
 
@@ -10,9 +7,6 @@
 
 
 [redirect-method.any.html]
-  [Redirect 303 with GET]
-    expected: FAIL
-
   [Redirect 307 with POST (string body)]
     expected: FAIL