Handle nonexistent images in CanvasRenderingContext2D.createPattern()

servo · Mar 13, 2020 · 3ec848f · 3ec848f
1 parent e3c91f7
commit 3ec848f
Show file tree

Hide file tree

Showing 12 changed files with 37 additions and 16 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/components/script/dom/htmlimageelement.rs b/components/script/dom/htmlimageelement.rs
@@ -167,13 +167,10 @@ impl HTMLImageElement {
     // https://html.spec.whatwg.org/multipage/#check-the-usability-of-the-image-argument
     pub fn is_usable(&self) -> Fallible<bool> {
         // If image has an intrinsic width or intrinsic height (or both) equal to zero, then return bad.
-        match &self.current_request.borrow().image {
-            Some(image) => {
-                if image.width == 0 || image.height == 0 {
-                    return Ok(false);
-                }
-            },
-            None => return Ok(false),
+        if let Some(image) = &self.current_request.borrow().image {
+            if image.width == 0 || image.height == 0 {
+                return Ok(false);
+            }
         }
 
         match self.current_request.borrow().state {

diff --git a/.../metadata-layout-2020/2dcontext/drawing-images-to-the-canvas/2d.drawImage.broken.html.ini b/.../metadata-layout-2020/2dcontext/drawing-images-to-the-canvas/2d.drawImage.broken.html.ini
@@ -0,0 +1,4 @@
+[2d.drawImage.broken.html]
+  [Canvas test: 2d.drawImage.broken]
+    expected: FAIL
+
diff --git a/...pt/metadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini b/...pt/metadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.broken.html]
+  [Canvas test: 2d.pattern.image.broken]
+    expected: FAIL
+
diff --git a/...tadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.nonexistent.html.ini b/...tadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.nonexistent.html.ini
diff --git a/...etadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.zeroheight.html.ini b/...etadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.zeroheight.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.zeroheight.html]
+  [Canvas test: 2d.pattern.image.zeroheight]
+    expected: FAIL
+
diff --git a/...metadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.zerowidth.html.ini b/...metadata-layout-2020/2dcontext/fill-and-stroke-styles/2d.pattern.image.zerowidth.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.zerowidth.html]
+  [Canvas test: 2d.pattern.image.zerowidth]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/2dcontext/drawing-images-to-the-canvas/2d.drawImage.broken.html.ini b/tests/wpt/metadata/2dcontext/drawing-images-to-the-canvas/2d.drawImage.broken.html.ini
@@ -0,0 +1,4 @@
+[2d.drawImage.broken.html]
+  [Canvas test: 2d.drawImage.broken]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini b/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.broken.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.broken.html]
+  [Canvas test: 2d.pattern.image.broken]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.nonexistent.html.ini b/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.nonexistent.html.ini
diff --git a/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.zeroheight.html.ini b/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.zeroheight.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.zeroheight.html]
+  [Canvas test: 2d.pattern.image.zeroheight]
+    expected: FAIL
+
diff --git a/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.zerowidth.html.ini b/tests/wpt/metadata/2dcontext/fill-and-stroke-styles/2d.pattern.image.zerowidth.html.ini
@@ -0,0 +1,4 @@
+[2d.pattern.image.zerowidth.html]
+  [Canvas test: 2d.pattern.image.zerowidth]
+    expected: FAIL
+