Update cssparser to fix CSS.escape test failures

Fixed failing tests #10685
servo · May 6, 2016 · 43b7253 · 43b7253
1 parent 0558687
commit 43b7253
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 43 deletions.
diff --git a/components/script/dom/css.rs b/components/script/dom/css.rs
@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 use cssparser::serialize_identifier;
-use dom::bindings::error::{Error, Fallible};
+use dom::bindings::error::Fallible;
 use dom::bindings::global::GlobalRef;
 use dom::bindings::reflector::Reflector;
 use util::str::DOMString;
@@ -16,9 +16,6 @@ pub struct CSS {
 impl CSS {
     // http://dev.w3.org/csswg/cssom/#serialize-an-identifier
     pub fn Escape(_: GlobalRef, ident: DOMString) -> Fallible<DOMString> {
-        if ident.bytes().any(|b| b == b'\0') {
-            return Err(Error::InvalidCharacter);
-        }
         let mut escaped = String::new();
         serialize_identifier(&ident, &mut escaped).unwrap();
         Ok(DOMString::from(escaped))

diff --git a/components/servo/Cargo.lock b/components/servo/Cargo.lock
diff --git a/ports/cef/Cargo.lock b/ports/cef/Cargo.lock
diff --git a/ports/geckolib/Cargo.lock b/ports/geckolib/Cargo.lock
diff --git a/ports/gonk/Cargo.lock b/ports/gonk/Cargo.lock
diff --git a/tests/wpt/metadata-css/cssom-1_dev/html/escape.htm.ini b/tests/wpt/metadata-css/cssom-1_dev/html/escape.htm.ini
@@ -1,14 +1,5 @@
 [escape.htm]
   type: testharness
-  [Null bytes]
-    expected: FAIL
-    bug: https://github.com/servo/servo/issues/10685
-
-  [Various tests]
-    expected: FAIL
-    bug: https://github.com/servo/servo/issues/10685
-
   [Surrogates]
     expected: FAIL
     bug: https://github.com/servo/servo/issues/6564
-