Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #4164 Make file.rs Constructor and new functions take GlobalRef…
… by value
- Loading branch information
1 parent
85df7f0
commit 5a54843
Showing
2 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a54843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from Ms2ger
at mattnenterprise@5a54843
5a54843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging mattnenterprise/servo/globalref-by-value = 5a54843 into auto
5a54843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mattnenterprise/servo/globalref-by-value = 5a54843 merged ok, testing candidate = 7800d98
5a54843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/480
success: http://build.servo.org/builders/linux2/builds/478
success: http://build.servo.org/builders/android/builds/515
success: http://build.servo.org/builders/mac1/builds/696
success: http://build.servo.org/builders/mac2/builds/697
5a54843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 7800d98