Accept only connected attributes for checkbox and radio activation be…

…haviour
servo · Mar 11, 2020 · 6284795 · 6284795
1 parent 4b1bb89
commit 6284795
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs
@@ -2488,6 +2488,9 @@ impl Activatable for HTMLInputElement {
                 // https://html.spec.whatwg.org/multipage/#checkbox-state-(type=checkbox):activation-behavior
                 // https://html.spec.whatwg.org/multipage/#radio-button-state-(type=radio):activation-behavior
                 // Check if document owner is fully active
+                if !self.upcast::<Node>().is_connected() {
+                    return ();
+                }
                 let target = self.upcast::<EventTarget>();
                 target.fire_bubbling_event(atom!("input"));
                 target.fire_bubbling_event(atom!("change"));

diff --git a/tests/wpt/metadata/dom/events/Event-dispatch-detached-input-and-change.html.ini b/tests/wpt/metadata/dom/events/Event-dispatch-detached-input-and-change.html.ini
@@ -2,21 +2,9 @@
   [attached to shadow dom radio should emit input and change events on click().]
     expected: FAIL
 
-  [detached checkbox should not emit input or change events on click().]
-    expected: FAIL
-
   [attached to shadow dom checkbox should emit input and change events on click().]
     expected: FAIL
 
-  [detached radio should not emit input or change events on click().]
-    expected: FAIL
-
-  [detached radio should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
-    expected: FAIL
-
-  [detached checkbox should not emit input or change events on dispatchEvent(new MouseEvent('click')).]
-    expected: FAIL
-
   [attached to shadow dom checkbox should emit input and change events on dispatchEvent(new MouseEvent('click')).]
     expected: FAIL