Make the rule tree actually threadsafe

RuleTree::gc is now a safe method that any thread can call at any time, and StrongRuleNode values can all be dropped whenever their owner want to, on any thread.
servo · Apr 20, 2020 · 7f54d14 · 7f54d14
1 parent 1c2de56
commit 7f54d14
Show file tree

Hide file tree

Showing 4 changed files with 315 additions and 319 deletions.
diff --git a/components/layout_thread/lib.rs b/components/layout_thread/lib.rs
@@ -1543,9 +1543,7 @@ impl LayoutThread {
         }
 
         // GC the rule tree if some heuristics are met.
-        unsafe {
-            layout_context.style_context.stylist.rule_tree().maybe_gc();
-        }
+        layout_context.style_context.stylist.rule_tree().maybe_gc();
 
         // Perform post-style recalculation layout passes.
         if let Some(mut root_flow) = self.root_flow.borrow().clone() {

diff --git a/components/layout_thread_2020/lib.rs b/components/layout_thread_2020/lib.rs
@@ -1184,9 +1184,7 @@ impl LayoutThread {
         }
 
         // GC the rule tree if some heuristics are met.
-        unsafe {
-            layout_context.style_context.stylist.rule_tree().maybe_gc();
-        }
+        layout_context.style_context.stylist.rule_tree().maybe_gc();
 
         // Perform post-style recalculation layout passes.
         if let Some(root) = &*self.fragment_tree_root.borrow() {