Don't include the root element when calling Element#getElementsByTagName

Fixes #4249
servo · Dec 9, 2014 · 8ed6ace · 8ed6ace · bors-servo · Dec 9, 2014
1 parent 02955d3
commit 8ed6ace
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/components/script/dom/htmlcollection.rs b/components/script/dom/htmlcollection.rs
@@ -85,7 +85,10 @@ impl HTMLCollection {
             ascii_lower_tag: Atom,
         }
         impl CollectionFilter for TagNameFilter {
-            fn filter(&self, elem: JSRef<Element>, _root: JSRef<Node>) -> bool {
+            fn filter(&self, elem: JSRef<Element>, root: JSRef<Node>) -> bool {
+                if NodeCast::from_ref(elem) == root {
+                    return false
+                }
                 if elem.html_element_in_html_document() {
                     *elem.local_name() == self.ascii_lower_tag
                 } else {

diff --git a/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini b/tests/wpt/metadata/dom/nodes/Element-getElementsByTagName.html.ini
@@ -8,7 +8,3 @@
 
   [getElementsByTagName(\'*\')]
     expected: FAIL
-
-  [Matching the context object]
-    expected: FAIL
-