Implementation of node.parentNode/parentElement

servo · Oct 23, 2013 · a4aa8b0 · a4aa8b0 · bors-servo · Oct 23, 2013
1 parent f3f6e62
commit a4aa8b0
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/components/script/dom/node.rs b/src/components/script/dom/node.rs
@@ -592,11 +592,11 @@ impl Node<ScriptView> {
     }
 
     pub fn GetParentNode(&self) -> Option<AbstractNode<ScriptView>> {
-        None
+        self.parent_node
     }
 
     pub fn GetParentElement(&self) -> Option<AbstractNode<ScriptView>> {
-        None
+        self.parent_node.filtered(|parent| parent.is_element())
     }
 
     pub fn HasChildNodes(&self) -> bool {

diff --git a/src/test/html/content/test_parentnodes.html b/src/test/html/content/test_parentnodes.html
@@ -0,0 +1,26 @@
+<html>
+<head>
+  <title></title>
+  <script src="harness.js"></script>
+</head>
+<body>
+  <div id="div1"></div>
+  <script>
+    // FIXME: This should be HTMLDocument.
+    //isnot(document.documentElement.parentNode, null);
+    is(document.documentElement.parentElement, null);
+
+    var elem = document.createElement("p");
+    is(elem.parentNode, null);
+    is(elem.parentElement, null);
+
+    var child = document.createElement("p");
+    elem.appendChild(child);
+
+    is(child.parentNode, elem);
+    is(child.parentElement, elem);
+
+    finish();
+  </script>
+</body>
+</html>