Skip to content

Commit

Permalink
Remove support for heartbeats profiling
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonSapin committed Jun 4, 2020
1 parent 0abe906 commit b282bd3
Show file tree
Hide file tree
Showing 14 changed files with 7 additions and 1,157 deletions.
24 changes: 0 additions & 24 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions components/config/opts.rs
Expand Up @@ -109,9 +109,6 @@ pub struct Opts {
/// Periodically print out on which events script threads spend their processing time.
pub profile_script_events: bool,

/// Enable all heartbeats for profiling.
pub profile_heartbeats: bool,

/// `None` to disable debugger or `Some` with a port number to start a server to listen to
/// remote Firefox debugger connections.
pub debugger_port: Option<u16>,
Expand Down Expand Up @@ -264,9 +261,6 @@ pub struct DebugOptions {
/// Profile which events script threads spend their time on.
pub profile_script_events: bool,

/// Enable all heartbeats for profiling.
pub profile_heartbeats: bool,

/// Paint borders along fragment boundaries.
pub show_fragment_borders: bool,

Expand Down Expand Up @@ -333,7 +327,6 @@ impl DebugOptions {
"dump-display-list-json" => self.dump_display_list_json = true,
"relayout-event" => self.relayout_event = true,
"profile-script-events" => self.profile_script_events = true,
"profile-heartbeats" => self.profile_heartbeats = true,
"show-fragment-borders" => self.show_fragment_borders = true,
"show-parallel-layout" => self.show_parallel_layout = true,
"trace-layout" => self.trace_layout = true,
Expand Down Expand Up @@ -397,10 +390,6 @@ fn print_debug_usage(app: &str) -> ! {
"profile-script-events",
"Enable profiling of script-related events.",
);
print_option(
"profile-heartbeats",
"Enable heartbeats for all thread categories.",
);
print_option(
"show-fragment-borders",
"Paint borders along fragment boundaries.",
Expand Down Expand Up @@ -509,7 +498,6 @@ pub fn default_opts() -> Opts {
dump_display_list_json: false,
relayout_event: false,
profile_script_events: false,
profile_heartbeats: false,
disable_share_style_cache: false,
style_sharing_stats: false,
convert_mouse_to_touch: false,
Expand Down Expand Up @@ -896,7 +884,6 @@ pub fn from_cmdline_args(mut opts: Options, args: &[String]) -> ArgumentParsingR
hard_fail: opt_match.opt_present("f") && !opt_match.opt_present("F"),
bubble_inline_sizes_separately: bubble_inline_sizes_separately,
profile_script_events: debug_options.profile_script_events,
profile_heartbeats: debug_options.profile_heartbeats,
trace_layout: debug_options.trace_layout,
debugger_port: debugger_port,
devtools_port: devtools_port,
Expand Down
3 changes: 0 additions & 3 deletions components/profile/Cargo.toml
Expand Up @@ -11,14 +11,11 @@ name = "profile"
path = "lib.rs"

[dependencies]
heartbeats-simple = "0.4"
ipc-channel = "0.14"
log = "0.4"
profile_traits = { path = "../profile_traits" }
serde = "1.0"
serde_json = "1.0"
servo_config = { path = "../config" }
time_crate = { package = "time", version = "0.1.12" }

[target.'cfg(target_os = "macos")'.dependencies]
task_info = { path = "../../support/rust-task_info" }
Expand Down
64 changes: 0 additions & 64 deletions components/profile/README.md

This file was deleted.

181 changes: 0 additions & 181 deletions components/profile/heartbeats.rs

This file was deleted.

4 changes: 0 additions & 4 deletions components/profile/lib.rs
Expand Up @@ -4,15 +4,11 @@

#![deny(unsafe_code)]

#[macro_use]
extern crate log;
#[macro_use]
extern crate profile_traits;
#[macro_use]
extern crate serde;

#[allow(unsafe_code)]
mod heartbeats;
#[allow(unsafe_code)]
pub mod mem;
pub mod time;
Expand Down

0 comments on commit b282bd3

Please sign in to comment.