Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bug of TextInput.adjust_horizontal causing stack overflow or wrap…
…around When the edit_point is in the first position of a multiline TextInput adjust_horizontal(-1) moves the edit_point to the end of the first line. When the first line is empty this causes a stack overflow. When the edit_point is in the last position adjust_horizontal(1) causes a stack overflow.
- Loading branch information
Showing
1 changed file
with
10 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5e7cba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from jdm
at ema-fox@b5e7cba
b5e7cba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging ema-fox/servo/textinput = b5e7cba into auto
b5e7cba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ema-fox/servo/textinput = b5e7cba merged ok, testing candidate = 9ac8175
b5e7cba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/201
success: http://build.servo.org/builders/linux2/builds/201
success: http://build.servo.org/builders/android/builds/268
success: http://build.servo.org/builders/mac1/builds/418
success: http://build.servo.org/builders/mac2/builds/418
b5e7cba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 9ac8175