Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement most of the important WindowProxy traps
- Loading branch information
Showing
5 changed files
with
146 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<html> | ||
<head id="foo"> | ||
<script src="harness.js"></script> | ||
</head> | ||
<body> | ||
<div></div> | ||
<script> | ||
window.abcd = 15; | ||
is(window.abcd, 15); | ||
is(Object.getOwnPropertyDescriptor(window, 'abcd').value, 15); | ||
is(window.hasOwnProperty('abcd'), true); | ||
|
||
is('location' in window, true); | ||
// FIXME: https://github.com/servo/servo/issues/4593 | ||
is(Object.hasOwnProperty('location'), false) | ||
|
||
// Can't set indexed properties | ||
window[100] = "abc"; | ||
is(window[100], undefined); | ||
is(Object.getOwnPropertyDescriptor(window, 1000), undefined); | ||
</script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d54a45a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from jdm
at evilpie@d54a45a
d54a45a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging evilpie/servo/window-proxy = d54a45a into auto
d54a45a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evilpie/servo/window-proxy = d54a45a merged ok, testing candidate = a227faa
d54a45a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://build.servo.org/builders/linux1/builds/518
success: http://build.servo.org/builders/linux2/builds/516
success: http://build.servo.org/builders/android/builds/554
success: http://build.servo.org/builders/mac1/builds/735
success: http://build.servo.org/builders/mac2/builds/735
d54a45a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = a227faa