Skip to content

Commit

Permalink
Use the correct origin in fetch
Browse files Browse the repository at this point in the history
  • Loading branch information
KiChjang committed Nov 15, 2017
1 parent 5227df2 commit d5e7137
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions components/net/http_loader.rs
Expand Up @@ -671,8 +671,10 @@ pub fn http_redirect_fetch(request: &mut Request,
request.redirect_count += 1;

// Step 7
// FIXME: Correctly use request's origin
let same_origin = location_url.origin() == request.current_url().origin();
let same_origin = match request.origin {
Origin::Origin(ref origin) => *origin == location_url.origin(),
Origin::Client => panic!("Request origin should not be client for {}", request.current_url()),
};
let has_credentials = has_credentials(&location_url);

if request.mode == RequestMode::CorsMode && !same_origin && has_credentials {
Expand All @@ -691,7 +693,7 @@ pub fn http_redirect_fetch(request: &mut Request,
}

// Step 10
if cors_flag && !same_origin {
if cors_flag && location_url.origin() != request.current_url().origin() {
request.origin = Origin::Origin(ImmutableOrigin::new_opaque());
}

Expand Down

0 comments on commit d5e7137

Please sign in to comment.