Skip to content

Commit

Permalink
make base all: Makefile rule conditional, only build embedding on non…
Browse files Browse the repository at this point in the history
…-android
  • Loading branch information
Mike Blumenkrantz committed May 1, 2014
1 parent 43326ac commit f2fbe68
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile.in
Expand Up @@ -287,7 +287,6 @@ include $(S)mk/clean.mk

.DEFAULT_GOAL := all
.PHONY: all
all: servo servo-embedding

# Servo helper libraries

Expand Down Expand Up @@ -338,6 +337,7 @@ $(BINDINGS_SRC)/ParserResults.pkl: $(globalgen_dependencies) \
# Servo binaries

ifneq ($(CFG_OSTYPE),linux-androideabi)
all: servo servo-embedding
servo: $(DEPS_servo)
@$(call E, compile: $@)
$(Q)$(RUSTC) $(RFLAGS_servo) -o servo $< --crate-type bin
Expand All @@ -352,6 +352,7 @@ servo-embedding: servo $(SRC_embedding) $(CRATE_embedding)
$(Q)$(RUSTC) $(RFLAGS_embedding) $(CRATE_embedding)
touch servo-embedding
else
all: servo
servo: $(DEPS_servo)
@$(call E, compile: $@)
$(Q)$(RUSTC) $(RFLAGS_servo) $< -o libservo.so --crate-type dylib
Expand Down

5 comments on commit f2fbe68

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from larsbergstrom
at zmike@f2fbe68

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging zmike/servo/embedding-base = f2fbe68 into auto

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zmike/servo/embedding-base = f2fbe68 merged ok, testing candidate = 96382ee

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors-servo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 96382ee

Please sign in to comment.