Skip to content

Commit

Permalink
mach run --debug: Try using rust-gdb/rust-lldb if available
Browse files Browse the repository at this point in the history
If the selected debugger (requested explicitly or detected by mozdebug)
is gdb or lldb, use rust-gdb or rust-lldb instead, if it's available in
the path and appears to be working.

(This should usually be the case when using the default debugger on
GNU/Linux or MacOS, as rust-gdb or rust-lldb is provided by the Rust
snapshot in use.)
  • Loading branch information
antrik committed Dec 24, 2015
1 parent 9412e71 commit f3cd5d2
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion python/servo/post_build_commands.py
Expand Up @@ -95,8 +95,17 @@ def run(self, params, release=False, dev=False, android=False, debug=False, debu
print("Could not find a suitable debugger in your PATH.")
return 1

command = self.debuggerInfo.path
if debugger == 'gdb' or debugger == 'lldb':
rustCommand = 'rust-' + debugger
try:
subprocess.check_call([rustCommand, '--version'], env=env, stdout=open(os.devnull, 'w'))
command = rustCommand
except (OSError, subprocess.CalledProcessError):
pass

# Prepend the debugger args.
args = ([self.debuggerInfo.path] + self.debuggerInfo.args +
args = ([command] + self.debuggerInfo.args +
args + params)
else:
args = args + params
Expand Down

0 comments on commit f3cd5d2

Please sign in to comment.