Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement position:relative #1613

Merged
merged 1 commit into from Feb 5, 2014
Merged

implement position:relative #1613

merged 1 commit into from Feb 5, 2014

Conversation

ksh8281
Copy link
Contributor

@ksh8281 ksh8281 commented Feb 4, 2014

implement position:relative

this pr implement #792
it gives same result with firefox in "src/test/ref/position_relative_a.html"
r? @larsbergstrom

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/722

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

highfive commented Feb 4, 2014

warning Warning warning

  • @ksh8281, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

@larsbergstrom
Copy link
Contributor

The two big changes that I would like to see are:

  • Correct the computation of left/right
  • Fix up both the determination and the naming of containing block instead of parent

If you can't easily find another way to do the reftest other than as an image, you can leave it as-is until we land more positioning options (e.g., position:fixed).

bors-servo pushed a commit that referenced this pull request Feb 5, 2014
implement position:relative

this pr implement #792
it gives same result with firefox in "src/test/ref/position_relative_a.html"
r? @larsbergstrom
@bors-servo bors-servo merged commit a90c2e3 into servo:master Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants