Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute selectors not working properly #1652

Closed
sonwow opened this issue Feb 10, 2014 · 1 comment
Closed

Attribute selectors not working properly #1652

sonwow opened this issue Feb 10, 2014 · 1 comment

Comments

@sonwow
Copy link
Contributor

sonwow commented Feb 10, 2014

It seems that there are some problems in #1561.

Currently default namespace of attribute selector is None.
However if the namespace of attribute selector is None, matched result will be false:
https://github.com/mozilla/servo/blob/master/src/components/main/layout/wrapper.rs#L241
So, attribute selectors not working.

What do you think of this? @SimonSapin
@SimonSapin
Copy link
Member

This is a bug. Fixing it now.

SimonSapin added a commit to SimonSapin/servo that referenced this issue Feb 10, 2014
@SimonSapin
Fix servo#1652: Attribute selectors should not have the default names…
a9d4753 
…pace applied.

The significant change is in the default_namespace() function.
The rest is only renaming a parameter and adding tests.
SimonSapin added a commit to SimonSapin/servo that referenced this issue Feb 10, 2014
@SimonSapin
Fix servo#1652: Attribute selectors should default to the null namespace
279ca64 
… and not "any namespace" or use the default namespace declaration.
therealglazou pushed a commit to therealglazou/servo that referenced this issue Feb 20, 2014
@SimonSapin @therealglazou
Fix servo#1652: Attribute selectors should default to the null namespace
b5495af 
… and not "any namespace" or use the default namespace declaration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonSapin @sonwow