Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Implement Loader#loadBytes #1646

Merged
merged 4 commits into from Sep 2, 2014
Merged

Conversation

tschneidereit
Copy link
Contributor

No description provided.

Preparation for Loader#loadBytes implementation.
With trace test.

This shares most code with `Loader#load` by extracting the creation of the parsing worker into a private method on Loader.
@tschneidereit
Copy link
Contributor Author

/botio test

@shumwaybot
Copy link

From: Bot.io (Main)


Received

Command cmd_test from @tschneidereit received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/5b4c9e666cb936c/output.txt

@shumwaybot
Copy link

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/5b4c9e666cb936c/output.txt

Total script time: 14.89 mins

@tschneidereit
Copy link
Contributor Author

/botio reftest

@shumwaybot
Copy link

From: Bot.io (Main)


Received

Command cmd_reftest from @tschneidereit received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/c9da100fa35445f/output.txt

@shumwaybot
Copy link

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/c9da100fa35445f/output.txt

Total script time: 11.60 mins

@tschneidereit
Copy link
Contributor Author

/botio reftest

@shumwaybot
Copy link

From: Bot.io (Main)


Received

Command cmd_reftest from @tschneidereit received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/ee927e46f00f199/output.txt

@shumwaybot
Copy link

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/ee927e46f00f199/output.txt

Total script time: 11.70 mins

@tschneidereit
Copy link
Contributor Author

/botio reftest

@shumwaybot
Copy link

From: Bot.io (Main)


Received

Command cmd_reftest from @tschneidereit received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/c83a64937dcf64c/output.txt

@shumwaybot
Copy link

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/c83a64937dcf64c/output.txt

Total script time: 11.61 mins

  • Lint: FAILED
  • Reference tests: Passed

With trace test.

This shares most code with `Loader#load` by extracting the creation of the parsing worker into a private method on Loader.
tschneidereit added a commit that referenced this pull request Sep 2, 2014
@tschneidereit tschneidereit merged commit 52575bf into mozilla:master Sep 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants