This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
Rewrite of most of the AVM2 component, plus lots of other changes to adapt to said rewrite #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h musn't be writable after initial definition Substantially reduces the amount of VM-internal exceptions in the acceptance tests suite because it prevents redefinition of Error subclasses, which threw off our error reporting.
…ation pushes its scope stack to Not yet used for anything, but required to make various dynamic scope things (such as in-scope XML namespaces and `flash.system.ApplicationDomain.currentDomain`) work.
…in for non-runtime names.
Makes the remaining two avm2/pass tests pass.
…We'll need to do this for all array methods.
…on-indexed properties correctly. This disables the descirbeJSON test because of some strange formatting issue that causes it not to diff correctly.
Conflicts: test/avm2/acceptance.baseline test/avm2/pass.baseline test/avm2/pass.txt
Conflicts: test/avm2/acceptance.baseline
They don't actually *do* anything, so this is more than trivial.
The native doesn't actually implement a single method, but at least we get the exception a slight bit later.
"Work around" might be a bit of a strong word here ...
|
/botio reftest |
From: Bot.io (Main)ReceivedCommand cmd_reftest from @yurydelendik received. Current queue size: 0 Live output at: http://areweflashyet.com:8081/7a55d6e95613aed/output.txt |
From: Bot.io (Main)FailedFull output at http://areweflashyet.com:8081/7a55d6e95613aed/output.txt Total script time: 5.90 mins
|
This regressed rendering of layers because it, I think, doesn't properly restore state such as global alpha.
|
Landed in squashed form in #2155. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't land right now, but getting close.