Implement LocalConnection #2225
Conversation
tschneidereit
force-pushed
the
localconnection
branch
2 times, most recently
from
fc1b134
to
54328b9
Compare
| @@ -273,6 +291,98 @@ var ShumwayCom = { | |||
| return; | |||
| } | |||
| onSystemResourceCallback = callback; | |||
| }, | |||
| createLocalConnection: function(connectionName, callback) { | |||
There was a problem hiding this comment.
Move this code into separate jsm-files (similar to RtmpUtils and SpecialInflateUtils). You can create e.g. localConnections object that will encapsulate the logic, the _getLocalConnection and localConnectionsRegistry can be moved there as well.
There was a problem hiding this comment.
Yes, I had planned on doing that.
There was a problem hiding this comment.
Also, place it under the preference for now.
And this is why all changes should go through review.
The various backends are stubbed out and do nothing whatsoever right now.
This fully works for the non-cross-domain case, and not in the extension. It'll change a bit to move error handling out of the message handler - across iframes we won't be able to create exceptions in the sender's `AXSecurityDomain`.
This fully works, including allowDomain. It needs very careful checking and probably a bugfix or two, though.
By setting it for the base URL and stripping it when loading files.
Contains a shell trace test. While the test only excerts the player-internal implementation of the message sending machinery, it does test all the content-facing parts and all error handling. I verified that the implementation works as expected across browser tabs (within the same browser instance, of course) with Manual testing.
tschneidereit
force-pushed
the
localconnection
branch
from
970cc85
to
8b5be8b
Compare
|
r? @yurydelendik after actually getting things working. |
|
Review status: 11 of 36 files reviewed, 6 unresolved discussions, some commit checks failed.
extension/firefox/chrome/ShumwayCom.jsm, line 120 [r3] (raw file): src/base/external.ts, line 54 [r3] (raw file): src/flash/display/LoaderInfo.ts, line 129 [r3] (raw file): src/flash/references.ts, line 64 [r3] (raw file): src/flash/references.ts, line 91 [r3] (raw file): src/player/player.ts, line 61 [r3] (raw file): Comments from the review on Reviewable.io |
|
Okay, reviewable.io does not allow fully review this PR
Could you submit a PR that will just move Player class? It's not related to this PR. If this PR depends on this, let's block it by the Player class refactoring. (Also, please notice that Travis is failing) |
|
Closing because reviewable.io really doesn't like this PR. Probably caused by first renaming player.ts and then doing the renaming in another PR, rebasing this one on top of that. Ideally, reviewable should just ignore the entire renaming operation, but it doesn't. Will open a fresh PR. |
Not finished, contains only the content-facing parts. Those should be pretty much done, though, modulo bug fixes.