Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Bug 1120688 - SWF #1662 "START NOW" button is magenta instead of using glow filter #2328

Merged
merged 6 commits into from Aug 27, 2015
Merged

Conversation

tobitailor
Copy link
Contributor

Review on Reviewable

@tobitailor
Copy link
Contributor Author

/botio reftest

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Received

Command cmd_reftest from @tobytailor received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/d2201ed3591778c/output.txt

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/d2201ed3591778c/output.txt

Total script time: 3.90 mins

@tobitailor
Copy link
Contributor Author

/botio reftest

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Received

Command cmd_reftest from @tobytailor received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/f41225cf5c0a6c6/output.txt

@tobitailor
Copy link
Contributor Author

/botio reftest

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Received

Command cmd_reftest from @tobytailor received. Current queue size: 1

Live output at: http://areweflashyet.com:8081/8da503688082b0a/output.txt

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/f41225cf5c0a6c6/output.txt

Total script time: 3.78 mins

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/8da503688082b0a/output.txt

Total script time: 3.79 mins

@yurydelendik
Copy link
Contributor

Looks good with empty spaces/lines changes addressed.

Checking trace tests again
/botio test


Reviewed 1 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


src/gfx/2d/surface.ts, line 98 [r3] (raw file):
nit: remove spaces (here and few below)


Comments from the review on Reviewable.io

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/dd2d5d6491ff09f/output.txt

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/dd2d5d6491ff09f/output.txt

Total script time: 11.70 mins

@tobitailor
Copy link
Contributor Author

/botio test

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Received

Command cmd_test from @tobytailor received. Current queue size: 0

Live output at: http://areweflashyet.com:8081/211fe77f69f8a0a/output.txt

@shumway-bot
Copy link
Contributor

From: Bot.io (Main)


Failed

Full output at http://areweflashyet.com:8081/211fe77f69f8a0a/output.txt

Total script time: 11.86 mins

tobitailor pushed a commit that referenced this pull request Aug 27, 2015
Bug 1120688 - SWF #1662 "START NOW" button is magenta instead of using glow filter
@tobitailor tobitailor merged commit f17b3c5 into mozilla:master Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants