Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Increase timeout for successful signing #319

Closed
diox opened this issue Oct 21, 2019 · 2 comments · Fixed by #338
Closed

Increase timeout for successful signing #319

diox opened this issue Oct 21, 2019 · 2 comments · Fixed by #338
Assignees

Comments

@diox
Copy link
Member

diox commented Oct 21, 2019

In https://github.com/mozilla/addons-server/issues/12622 AMO is going to refactor the way unlisted submissions are handled, and have them go through the same auto-approval process as listed ones.

Validation and signing will continue to be automatic, but signing will no longer directly follow validation and may take more time to complete than before. This is an issue because sign-addon expects signing to be almost instantaneous and has a 2 minutes timeout before reporting an error. That timeout needs to be updated to a higher value to leave time for signing to succeed.

The value of the timeout we need is currently being discussed, I'll add it to this issue as soon as possible.

@diox

This comment has been minimized.

@diox diox self-assigned this Oct 21, 2019
@diox

This comment has been minimized.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants