-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor unlisted submission to go through auto-approval workflow #7047
Comments
We've done some back of a napkin maths to see if |
@jvillalobos I'll need copy for last page of the submission process. It currently says:
We can't include the link anymore since the unlisted approval will no longer be guaranteed to be instantaneous with those changes (*) So what can we say here instead ? (*) The developer will still receive the notification email once it's approved & signed though - it currently says:
|
/cc @caitmuenster |
LGTM. Thanks! |
QA: nothing should change except for this:
So, try submitting unlisted versions, both using devhub and the API, and see if it gets approved correctly, shows up in reviewer tools, have the right status in devhub, and relevant activity logs are created as before. |
Verified fixed on -dev. Unlisted extensions are no longer instantly signed, their auto-approval will happen in ~5 minutes.
The submission success message has been updated as well, and the the email notification is sent only after the add-on is auto-approved. The issues found with unlisted themes and delay auto-approval have been reported separately. |
We want to unify listed & unlisted submission workflow to make it easier to manage, as well as making it possible to apply some actions to unlisted uploads while they are scanned, such as delaying their approval.
For developers, that will mean although unlisted approvals should still be fast, it will no longer be instantaneous.
This means:
submit_file
task (currently fired for API uploads only),auto_approve
cron, or a different cron. (Noteauto_approve
was recently fixed to only care about listed versions, that would need to be reverted if going this route). We might want to have them go throughAutoApprovalSummary
too, to be determined.This should be done behind a waffle switch and maybe split into several issues if necessary.
The text was updated successfully, but these errors were encountered: