This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
update to es6 promises and remove when dependency #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccarruitero
force-pushed
the
es6-promises
branch
from
3562c8f
to
97e330b
Compare
|
That looks like something we want. What do you think @kumar303? |
kumar303
reviewed
Sep 10, 2019
| response.responseBody); | ||
|
|
||
| if (response.responseError instanceof Error) { | ||
| throw response.responseError; |
There was a problem hiding this comment.
Does this still work the same as before? I'm not sure what was going on with the callbacks.
There was a problem hiding this comment.
In other words, do tests that rely on error responses still get the same behavior? To research it, you could try and make one of the tests fail that was relying on this mock.
|
@ccarruitero this would need to be rebased on master to pick up the new |
ccarruitero
force-pushed
the
es6-promises
branch
from
97e330b
to
42c3fd1
Compare
kumar303
approved these changes
Sep 24, 2019
This was referenced Sep 24, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.