Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update devices.json - adds Samsung Galaxy S7 and S8 #22

Merged
merged 1 commit into from
May 23, 2017

Conversation

lllopo
Copy link
Contributor

@lllopo lllopo commented May 23, 2017

No description provided.

Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

@jryans jryans merged commit f5e5593 into mozilla:master May 23, 2017
@jryans
Copy link
Contributor

jryans commented May 23, 2017

Oops, I should have checked the featured flag. We only want that set for devices that "commonly used", which we've so far determined based on the "Growing Business" list from BrowserStack.

Looks like S7 is there, but S8 is not, so I'll flip featured to false for S8.

@lllopo
Copy link
Contributor Author

lllopo commented May 24, 2017

@jryans Thx. I wasn't really sure what the "featured" serves for, to be honest 😄 ... so I just copied the S6 value.

@jryans
Copy link
Contributor

jryans commented May 24, 2017

No worries, probably the README should explain it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants