Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Server Kaldi STT connection closing is buggy #18

Closed
kdavis-mozilla opened this issue Mar 30, 2016 · 1 comment
Closed

Server Kaldi STT connection closing is buggy #18

kdavis-mozilla opened this issue Mar 30, 2016 · 1 comment

Comments

@kdavis-mozilla
Copy link

A Kaldi STT connection to the server can be closed by the client or the server.

The current implementation handles the case in which the client closes the
connection correctly, but not the case in which the server closes it.

The code should be changed to handle both cases.

@kdavis-mozilla kdavis-mozilla changed the title Server STT connection closing is buggy Server Kaldi STT connection closing is buggy Mar 30, 2016
@kdavis-mozilla
Copy link
Author

I have a fix[1], as much as is possible, in code local to to this repo.

However, there is a bug in the repo Java-WebSocket that we indirectly depend on that also must be fixed.

In particular, when a WebSocketClient is closed[2] what it first does is close it's socket[3], then notify the listeners[4][5] the socket is closed.

However, in the time between closing the socket and notifying the listeners any WebSocketClient subclass is unaware the socket is closed and thus continues to send data. It does so on a closed socket which leads to an exception.

The solution is to reverse the order in the method onWebsocketClose() and call onClose() before calling socket.close()

@kdavis-mozilla kdavis-mozilla mentioned this issue Mar 31, 2016
andrenatal added a commit that referenced this issue Apr 7, 2016
tilmankamp pushed a commit to tilmankamp/smarthome that referenced this issue Apr 13, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
andrenatal pushed a commit to andrenatal/smarthome that referenced this issue Apr 13, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp pushed a commit to tilmankamp/smarthome that referenced this issue Apr 20, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp pushed a commit to tilmankamp/smarthome that referenced this issue Apr 21, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp pushed a commit to tilmankamp/smarthome that referenced this issue May 9, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp pushed a commit to tilmankamp/smarthome that referenced this issue Jun 8, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant