This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
forked from eclipse-archived/smarthome
-
Notifications
You must be signed in to change notification settings - Fork 8
Server Kaldi STT connection closing is buggy #18
Comments
I have a fix[1], as much as is possible, in code local to to this repo. However, there is a bug in the repo Java-WebSocket that we indirectly depend on that also must be fixed. In particular, when a WebSocketClient is closed[2] what it first does is close it's socket[3], then notify the listeners[4][5] the socket is closed. However, in the time between closing the socket and notifying the listeners any WebSocketClient subclass is unaware the socket is closed and thus continues to send data. It does so on a closed socket which leads to an exception. The solution is to reverse the order in the method onWebsocketClose() and call |
Closed
tilmankamp
pushed a commit
to tilmankamp/smarthome
that referenced
this issue
Apr 13, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
andrenatal
pushed a commit
to andrenatal/smarthome
that referenced
this issue
Apr 13, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp
pushed a commit
to tilmankamp/smarthome
that referenced
this issue
Apr 20, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp
pushed a commit
to tilmankamp/smarthome
that referenced
this issue
Apr 21, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp
pushed a commit
to tilmankamp/smarthome
that referenced
this issue
May 9, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
tilmankamp
pushed a commit
to tilmankamp/smarthome
that referenced
this issue
Jun 8, 2016
Signed-off-by: Kelly Davis <kdavis@mozilla.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
A Kaldi STT connection to the server can be closed by the client or the server.
The current implementation handles the case in which the client closes the
connection correctly, but not the case in which the server closes it.
The code should be changed to handle both cases.
The text was updated successfully, but these errors were encountered: