Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

potential redirect loop while preventing sidebar from changing domains #5

Closed
mhammond opened this issue Mar 18, 2012 · 1 comment
Closed

Comments

@mhammond
Copy link
Member

We have a location change watcher to ensure the sidebar never moves from the correct domain. If it detects such movement it does a goBack() call to take us back to the correct domain.

Consider a scenario where a page on the correct domain ends up doing a redirect to a page off the domain. When we do goBack() we wind up back at the page doing the redirect, so the process would repeat indefinitely.

A possible solution might be to always return to the "start" page for the service - although that would suffer the same problem in the (unlikely) case the main page does a redirect.

@mixedpuppy
Copy link
Member

fixed by getting the location change intercepting corrected

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants