Merge pull request #394 from rhelmer/bug884623-empty-signature-correl…

…ation-platform-failure bug 884623 - do not require platform for correlations check
mozilla · Jun 26, 2013 · 1279a0a · 1279a0a
2 parents c2d7809 + 430ff10
commit 1279a0a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/crashstats/crashstats/models.py b/crashstats/crashstats/models.py
@@ -823,8 +823,8 @@ class Correlations(SocorroMiddleware):
         'report_type',
         'product',
         'version',
-        'platform',
         'signature',
+        'platform',
     )
 
 
@@ -836,5 +836,7 @@ class CorrelationsSignatures(SocorroMiddleware):
         'report_type',
         'product',
         'version',
+    )
+    possible_params = (
         ('platforms', list),
     )
diff --git a/crashstats/crashstats/tests/test_models.py b/crashstats/crashstats/tests/test_models.py
@@ -952,6 +952,10 @@ def mocked_get(url, **options):
                     version='1.0a1',
                     platforms=['Windows NT', 'Linux'])
         eq_(r['total'], 2)
+        r = api.get(report_type='core-counts',
+                    product='WaterWolf',
+                    version='1.0a1')
+        eq_(r['total'], 2)
 
 
 class TestModelsWithFileCaching(TestCase):

diff --git a/crashstats/crashstats/views.py b/crashstats/crashstats/views.py
@@ -1045,8 +1045,6 @@ def report_list(request, default_context=None):
             context['table'][buildid][os_name] += 1
 
     correlation_os = max(os_count.iterkeys(), key=lambda k: os_count[k])
-    if correlation_os is None:
-        correlation_os = ''
     context['correlation_os'] = correlation_os
 
     correlation_version = max(version_count.iterkeys(),