This repository has been archived by the owner on Feb 1, 2018. It is now read-only.
implemented daily for crashstats fixes bug 788043 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,3 +24,19 @@ def urlencode(txt): | |||
| if isinstance(txt, unicode): | |||
| txt = txt.encode('utf-8') | |||
| return urllib.quote_plus(txt) | |||
|
|
|||
| @register.filter | |||
| def digitgroupseparator(int_): | |||
There was a problem hiding this comment.
just call it number to avoid the name clash :)
|
Things I am unhappy with about this patch:
Point 3 could probably be helped if I knew more about jinja templating, there are neat looping constructs in the docs that I don't quite grok yet. |
| <td> | ||
| <select id="daily_search_version_form_products" name="p"> | ||
| {% for product_name in products %} | ||
| {% if product == product_name %} |
There was a problem hiding this comment.
Please change this to:
<option value="{{ product_name }}" {% if product == product_name %}selected{% endif %}
>{{ product_name }}</option>To avoid possibly DRY.
|
Test coverage is a big weak but I'm not going to block because I think post-launch this is going to need to be significantly reviewed anyway (...I seem to remember from a irc chat). r+ |
This builds on code from Schalk Neethling <sneethling@mozilla.com> and Brandon Savage <brandon@brandonsavage.net>
rhelmer
added a commit
that referenced
this pull request
Oct 12, 2012
implemented daily for crashstats fixes bug 788043
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on code from Schalk Neethling sneethling@mozilla.com
and Brandon Savage brandon@brandonsavage.net