This repository has been archived by the owner on Feb 1, 2018. It is now read-only.
bug 846815 - always pass product to report/list page #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@lonnen r? |
|
I don't mean to hijack this review, which I don't, but there's got be time now to refactor these long hideous URLs in templates. Like a function in helpers.py that takes |
| @@ -104,7 +104,7 @@ | |||
| <td title="A change of {{ (crash.changeInPercentOfTotal * 100) | round(2) }}% from {{ (crash.previousPercentOfTotal * 100) | round(2) }}%">{{ (crash.changeInPercentOfTotal * 100) | round(2) }}%</td> | |||
| {% endif %} | |||
| <td> | |||
| <a class="signature" href="{{ url('crashstats.report_list') }}?range_value={{ days }}&range_unit=days&date={{ tcbs.end_date }}&signature={{ crash.signature|urlencode }}&version={{ product }}%3A{{ version }}" title="{{ crash.signature }}">{{ crash.signature|truncate(length=80, killwords=True) }}</a> | |||
| <a class="signature" href="{{ url('crashstats.report_list') }}?product={{ product}}&range_value={{ days }}&range_unit=days&date={{ tcbs.end_date }}&signature={{ crash.signature|urlencode }}&version={{ product }}%3A{{ version }}" title="{{ crash.signature }}">{{ crash.signature|truncate(length=80, killwords=True) }}</a> | |||
There was a problem hiding this comment.
?product={{ product}}& is missing a matching space.
|
One minor nit and then its r+. Feel free to hit the button yourself. |
|
@peterbe - please file a bug for refactoring long URLs. We are still yet to switch to django crash-stats for production, so I'd rather not tackle this yet. |
rhelmer
added a commit
that referenced
this pull request
Mar 19, 2013
…-reportlist bug 846815 - always pass product to report/list page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.