-
Notifications
You must be signed in to change notification settings - Fork 15
WIP: Puppetize the rest of Jenkins / buildbox build #109
base: master
Are you sure you want to change the base?
Conversation
'gdb', | ||
'glibc-devel', | ||
'glibc-headers', | ||
'golang', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need Go? IIRC this was in order to build Terraform, which we're not doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure? We can hack it out of there if we're not using any Go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we also had it for building DeadCI (as I had patched it), but were not using that either. Yeah, I Think we're good to remove golang
and associated packages for now.
} | ||
|
||
package { 'jenkins': | ||
ensure => installed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check your spacing here. :) Two spaces - not four.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you talking about Willis?
Just noticed something. |
Merge conflicts were actually quite minimal! |
]: | ||
ensure => latest, | ||
require => Package['epel-release', 'yum-plugin-fastestmirror'] | ||
} | ||
|
||
exec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I didn't catch this exec
, but I'm glad that I caught it, heh.
Please use the built-in Puppet types to manage this repo - you can see an example of how to do this in puppet/modules/socorro/manifests/packer/base.pp
.
Well, this new rum repo setup is giving me this: I'll have to nail that down before merging. |
Any hints @phrawzty ? |
Add an exec to add jenkins repo Make templates to drop in secret files, put configure type files in etc jenkins Add in missing template Fix linter errors Please travis by removing spaces Fix missing comma Update naming on socorro amis to be YYYY-mm-dd, update additional policies attached in iam to jenkins user in README Such a complainer travis Such a complainer travis Remove dupe git from buildbox packer manifest Remove more golang Remove more golang Alphabetize and remove dupes in buildbox packer list Fix mode on sh script Fully qualify and dependency chain for adding jenkins repo No need to wait for rpm No sudo in build Have jenkins source yum instead of rpm Fix some paths Fix location of etc sysconfig jenkins Get puppet to do hiera correctly Fix etc jenkins Fix name for passphrase Move manage_repo.sh into version control, templated Cause repo to init on instantiation Fix repo-init Make travis happy 777 Fix incorrect secret_bucket value No wget dupe Beginning my make up work to travis, the formatting kang Remove wget depend Use predefined standard for adding yum repos Fix yumrepo No need to init repo for a build Remove depend on repo init Fix path to env infra list Be honest about number of tries README updates Fix name of passphrase.txt More readme Data dir needs to be owned by centos Remove entire data dir More README Add rpm macros file
No description provided.