This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
[WIP DO NOT MERGE] Cleanup leftover volumes on each deploy #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a few instances where we hit our volume limits, so I propose that each time we do a deploy, we clean those up.
We had this discussion previously, and balked at the idea because we had a lot more we were doing in terms of making test servers.
My calculation is that any volumes we have that people care about have sat there unused for a year. If we haven't needed it by now, it's hard to see why we would later. The script will only kill unused volumes which are 8gb in size. Servers like analysis whose volumes we may one day want to detach and move or copy are sized differently.
@phrawzty @willkg at your convenience, would love your thoughts.