This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
fix bug 1146449; pass the secret bucket name to Hiera on provision #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require both a rebuild of the Base and Buildbox AMIs, as well as an update of the Puppet provision archive. |
|
r+ |
phrawzty
added a commit
that referenced
this pull request
Mar 25, 2015
fix bug 1146449; pass the secret bucket name to Hiera on provision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am extending the pattern of passing arbitrary information (in this case, the secret bucket name) via
user_data. This value is then picked up (positionally) bysocorro_role.shand applied tohiera.yaml, thus allowing us to configurehiera-s3without exposing the name of the secret bucket. Once again, I'm not sure if this is clever or janky - possibly both - but it should work. 馃槇This also touches on bug 1146447.
@rhelmer
r?