Merge pull request #2952 from Tchanders/delete-hover

Fixes Bug 1194306 - Style signature page panel delete buttons on hover
mozilla-services · Aug 17, 2015 · df417e3 · df417e3
2 parents 3c9d2fa + 932f5ea
commit df417e3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/webapp-django/crashstats/signature/static/signature/css/signature_report.less b/webapp-django/crashstats/signature/static/signature/css/signature_report.less
@@ -129,13 +129,18 @@ section.aggregations-panel {
     }
 }
 
-.tab-inner-panel .delete {
-    background-image: url('../../img/3rdparty/silk/cross.png');
-    display: inline-block;
-    float: right;
-    height: 16px;
-    margin-top: 10px;
-    padding: 4px;
-    text-indent: -9999px;
-    width: 16px;
+.tab-inner-panel {
+    .delete {
+        background-image: url('../../img/3rdparty/silk/cross.png');
+        display: inline-block;
+        float: right;
+        height: 16px;
+        margin-top: 10px;
+        padding: 4px;
+        text-indent: -9999px;
+        width: 16px;
+    }
+    .delete:hover {
+        cursor: pointer;
+    }
 }
diff --git a/webapp-django/crashstats/signature/static/signature/js/signature_panel.js b/webapp-django/crashstats/signature/static/signature/js/signature_panel.js
@@ -9,8 +9,7 @@ SignatureReport.Panel = function (panelName, onDelete) {
     var $headingElement = $('<h2>', {
         'text': SignatureReport.capitalizeHeading(panelName)
     });
-    var $deleteButton = $('<a>', {
-        'href': '#',
+    var $deleteButton = $('<div>', {
         'class': 'options delete',
         'text': 'X'
     });