Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug 1064355 - /contribute.json 404ing on stage and prod #2341

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Sep 8, 2014

@@ -52,6 +52,8 @@ rsync -a scripts/stackwalk.sh $BUILD_DIR/stackwalk/bin/
rsync -a analysis $BUILD_DIR/
rsync -a alembic $BUILD_DIR/application
rsync -a webapp-django $BUILD_DIR/
# because this file is served from the the `webapo-django/..` directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webapo? :-)

Also, I would remove the ..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also says "the the"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think either of us had enough caffeine when working on this.

@peterbe
Copy link
Contributor Author

peterbe commented Sep 8, 2014

Updated.

@peterbe
Copy link
Contributor Author

peterbe commented Sep 8, 2014

PS. When you r, please don't merge.

@bramwelt
Copy link
Contributor

bramwelt commented Sep 9, 2014

@peterbe Could you clarify why not to merge?

@peterbe
Copy link
Contributor Author

peterbe commented Sep 9, 2014

@peterbe Could you clarify why not to merge?

Because the commit messages are poopy. The second one just says "correction".
I like to rebase and squash and run it one last time before I commit to master.

@bramwelt
Copy link
Contributor

bramwelt commented Sep 9, 2014

Ah, thanks!

-:poop:

r+

@peterbe peterbe force-pushed the bug-1064355-contributejson-still-not-accessible-on-stage-or-prod branch from 00f8911 to 10f5470 Compare September 9, 2014 22:52
peterbe pushed a commit that referenced this pull request Sep 10, 2014
…l-not-accessible-on-stage-or-prod

fixes bug 1064355 - /contribute.json 404ing on stage and prod
@peterbe peterbe merged commit ec18591 into mozilla-services:master Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants