Fixes Bug 1172511 - examples of CountAnythingRules for the processor #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twobraids
changed the title
|
@AdrianGaudebert could you have a look at these when you return? |
|
r+ lgtm, these won't be activated until we enable them via config |
|
Don't we have unit tests for rules? If not, should we have some? It looks all simple and good, but unit tests are still a nice thing to have imho. |
lonnen
added a commit
that referenced
this pull request
Sep 2, 2015
Fixes Bug 1172511 - examples of CountAnythingRules for the processor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a demo of what can be done with the statsd classes and processor rules...
this change creates a base counter rule class and then uses it to define two processor rules that detect conditions during processing and then increment a statsd counter.
CountStackWalkerTimeoutKills will track how many times the stackwalker is killed for taking too long.
CountStackWalkerFailures will track how many times the stackwalker crashes or returns a bad error code.