Fixes Bug 1191509 - New signature reports tab to show graphs based on date histogram aggregations

[Tchanders]

No description provided.

[Tchanders]

@AdrianGaudebert A few things about these graphs:

I wasn't sure what default options were best, so I just went for Product for now.

I had to populate elastic search with some extra stuff here in order to get different lines to show on the graphs, so I added three extra fake signatures with c. 2, 10 and 20 products (this many products may be unrealistic, but there might be this many of some other field). Metrics Graphics only shows the first five lines by default:

(You can see by the legend that there are actually c. 20 lines of data here.)

Adding classes for the extra lines does make them display, but it looks too crowded:

(...in any case you still get the same problem - if you add twenty extra classes but there are thirty lines, only the first twenty will show up.)

[Tchanders]

We could sort by which lines have the highest counts and just show the top 5 (but we'd have to choose between highest average and highest maximum count). Or we could just show the graph with 5 lines but let the user know that there are more lines, and let them select which they want to see?

[adngdb]

s/Aggregate on/Graph of. Or something better.

[adngdb]

Let's show only the top 4 lines, and use those with the maximum total number of results. To find out which are the top results, add a facet on the field, and use the results from that facet: they will be sorted by descending number.

For example: http://socorro/supersearch/?_histogram.date=version&_facets=version

Returns:

{
  "facets": {
    "histogram_date": ["..."] ,
    "version": [
      { "term": "WaterWolf", "count": 42 },
      { "term": "NightTrain", "count": 41 },
    ]
  }
}

On the graph, if there are more than 4 different lines, add a note saying something like "Showing top 4 results out of XX, not showing: a, b, c... ".

[Tchanders]

New version with those changes.

[adngdb]

This is looking very very good! I'm excited to finally see graphs in the signature report page!!! :)

I think the only comment I have is that when you hover a particular point, the MG tip tells you the number of crashes but does not tell you what it is for (for example, if I'm looking at a graph of count of crashes per version, when I hover a point I'd like it to tell me that these numbers are for version X or Y).

And now for the actual last comment: where are my unit tests? :)

[Tchanders]

@AdrianGaudebert Here they are!

[adngdb]

Looking excellent! However, you are conflicting with @peterbe work in #2924, and he is going to merge that today. Once that PR is merged, can you please rebase this one and change your unit test code so that it matches the new way of mocking SuperSearch introduce in #2924?

[Tchanders]

@AdrianGaudebert Good to squash?

[adngdb]

Yes! Excellent! I'll merge as soon as it's ready to go. :)

[Tchanders]

@AdrianGaudebert Done!

[adngdb]

Heh, I just noticed: when you have several graphs and you hover a point in one of the graphs, it changes the top-right legend for all graphs! Not sure if that's a bug in your code or in MG, but that's not a blocker anyway. I'm merging this anyway, can you file a bug to figure that issue out?

[Tchanders]

Oops, yes I should be able to fix that!