Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type definitions for initialize method #405

Closed
wants to merge 1 commit into from

Conversation

willwillems
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Sep 2, 2019

Pull Request Test Coverage Report for Build 564

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.385%

Totals Coverage Status
Change from base Build 550: 0.0%
Covered Lines: 824
Relevant Lines: 911

💛 - Coveralls

@danvoyce
Copy link

Any chance of getting this merged one day?

Copy link
Contributor

@ochameau ochameau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch.

Sorry for getting back to you so late, but main contributors to this package went away from this project.

I'd be happy to merge this pull request if you rebase and address the arraybuffer issue.

@@ -78,6 +78,10 @@ export interface CodeWithSourceMap {
map: SourceMapGenerator;
}

export interface SourceMapConsumerInitialisationOptions {
"lib/mappings.wasm": string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be an ArrayBuffer:

if (typeof mappingsWasm === "string") {
return fetch(mappingsWasm).then(response => response.arrayBuffer());
}
if (mappingsWasm instanceof ArrayBuffer) {
return Promise.resolve(mappingsWasm);
}

@rmuratov
Copy link

rmuratov commented Aug 24, 2023

Looks like this is already in the master (but not published to npm yet).

@willwillems
Copy link
Author

@rmuratov thanks! In that case I'm closing this one, tbh I don't even remember creating it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants