This repository has been archived by the owner on Jun 19, 2019. It is now read-only.
fix compartments #169
Merged
fix compartments #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is very weird. Firstly it's based off of the now defunct stub branch. Also it includes quite a few commits, not sure why. Can you please rebase your fix as a single commit on top of the current master? Thanks! |
|
On Thu, Jul 21, 2016 at 12:27:22PM -0700, Ehsan Akhgari wrote:
because I'm dumb, all the other patches are unrelated, and I just forgot |
it doesn't work to store the old compartment in a context because a context can be reentered in which case we'd say the previous context was our selves, and then be unable to unwind the stack. However we already have a stack of entered contexts, and those should directly map to compartments. So it should be possible to use the context stack to get the compartment we want to leave to.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change