Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Ignore the order-alphabetical CSSLint rule. #173

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Ignore the order-alphabetical CSSLint rule. #173

merged 1 commit into from
Feb 26, 2018

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Jan 4, 2018

No description provided.

@fmarier
Copy link
Contributor

fmarier commented Feb 23, 2018

Is there a good reason we should ignore this lint rule?

As far as I know, that rule exists to make CSS more compressible under gzip & friends.

@XhmikosR
Copy link
Collaborator Author

Oh, I thought you didn't care about it, that is all. The rule is "new" so it wasn't there when I first added CSS Lint here.

I can adapt the code for this if you prefer this approach.

@XhmikosR
Copy link
Collaborator Author

BTW my plan was to switch to Stylelint eventually.

@XhmikosR
Copy link
Collaborator Author

So, I'd say just merge this as it is for now, and we can improve things when we switch to stylelint which is a much better solution.

@fmarier
Copy link
Contributor

fmarier commented Feb 26, 2018

I'd rather not disable this rule since I think it's a good one.

Not opposed to switching how the CSS is done, but in a way, merging this pull request as-is would be going against where we want to end up.

@XhmikosR
Copy link
Collaborator Author

The thing is that 1. CSS Lint is unmaintained and 2. the rule doesn't break the build as it should.

I still suggest that you merge this as is, and I'll make the switch to stylelint after my PRs are merged.

@fmarier
Copy link
Contributor

fmarier commented Feb 26, 2018

If that rule is not breaking the build, is there any point in disabling it?

@XhmikosR
Copy link
Collaborator Author

There's no point in having it either ;)

Like I said, CSS Lint is unmaintained. This just makes sure we don't get any warnings.

Everything will be much better after the stylelint switch.

@fmarier fmarier merged commit 9b336d9 into mozilla:master Feb 26, 2018
@XhmikosR XhmikosR deleted the xmr-csslint branch February 26, 2018 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants