Add hapi-require-https.

[XhmikosR]

If the production script is running npm start this will work out of the box. Otherwise we might need to set the env var NODE_ENV to production.

Requires the previous PRs merged.

Fixes #122.

/CC @fmarier

[XhmikosR]

We could check here for another environment variable if present. Not sure if Heroku is used and what is set exactly, so let me know.

[XhmikosR]

ping @fmarier

[XhmikosR]

Ping @fmarier

[XhmikosR]

On a side note, I have personally switched to Node.js 10.x. Should I make the same here too? Otherwise I can't rebase/update the deps or anything.

[MatthewHerbst]

@XhmikosR since this is open-source, it might be good to wait until October when Node.js 10 gets LTS.

[XhmikosR]

I don't see how it's related. I use it, and I'm not going to install 8.x to make changes to this project only.

[MatthewHerbst]

For easy Node switching you can use nvm or nodenv. You can set them up (simple script) to listen to the value of any .node-version file or the engines listing within package.json.

It's related because some people may not be able to use Node 10 in their work environments due to it not being LTS yet. You don't know how else this code is being used or by whom, and imho, it seems unnecessarily restrictive to force users to use Node 10 for this code.

[XhmikosR]

I know all of these, but I'm on Windows. Sorry, I'm not going to change my workflow. The node 10.x switch seems fine to me, I'm using it for months without an issue.

I don't see anyone else doing anything on this project apart from me.

[XhmikosR]

@mozfreddyb: can you share a few details about the Heroku env? Here I rely on an environment variable which I assume is set on Heroku to force the redirect to https.

[mozfreddyb]

I don't think we're setting any env variables in heroku itself. It just does npm start

[XhmikosR]

OK, then this should work out of the box since I'm setting NODE_ENV to production in the npm start script.

Can we test this somehow before merging it?

[mozfreddyb]

I don't think so. I'll carve out some time later this week to test-deploy and roll back if things go horribly wrong

[XhmikosR]

@mozfreddyb: how do you want to proceed with this? https://srihash.org/ doesn't even respond anymore.

[XhmikosR]

I'm gonna close this for now. I will keep the branch in this repo if we need it again.