Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Update dependencies to enable Greenkeeper 🌴 #225

Merged
merged 3 commits into from
Mar 1, 2019

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Feb 28, 2019

Let’s get started with automated dependency management for srihash.org 💪

🔒 Greenkeeper has found a package-lock.json file in this repository. Greenkeeper supports lockfile updates for public packages. If you use private packages in your repository, please use greenkeeper-lockfile to make sure these can get updated as well.

This pull request updates all your dependencies to their latest version. Having them all up to date really is the best starting point for keeping up with new releases. Greenkeeper will look out for further dependency updates and make sure to handle them in isolation and in real-time, but only after you merge this pull request.

Important: Greenkeeper will only start watching this repository’s dependency updates after you merge this initial pull request.


🏷 How to check the status of this repository

Greenkeeper adds a badge to your README which indicates the status of this repository.

This is what your badge looks like right now 👉 Greenkeeper badge

🙈 How to ignore certain dependencies

You may have good reasons for not wanting to update to a certain dependency right now. In this case, you can change the dependency’s version string in the package.json file back to whatever you prefer.

To make sure Greenkeeper doesn’t nag you again on the next update, add a greenkeeper.ignore field to your package.json, containing a list of dependencies you don’t want to update.

// package.json
{
  
  "greenkeeper": {
    "ignore": [
      "package-names",
      "you-want-me-to-ignore"
    ]
  }
}
👩‍💻 How to update this pull request
  # Change into your repository’s directory
  git fetch --all
  git checkout greenkeeper/initial
  npm install-test
  # Adapt your code until everything works again
  git commit -m 'chore: adapt code to updated dependencies'
  git push https://github.com/mozilla/srihash.org.git greenkeeper/initial
✨ How do dependency updates work with Greenkeeper?

After you merge this pull request, Greenkeeper will create a new branch whenever a dependency is updated, with the new version applied. The branch creation should trigger your testing services and check whether your code still works with the new dependency version. Depending on the the results of these tests Greenkeeper will try to open meaningful and helpful pull requests and issues, so your dependencies remain working and up-to-date.

-  "underscore": "^1.6.0"
+  "underscore": "^1.7.0"

The above example shows an in-range update. 1.7.0 is included in the old ^1.6.0 range, because of the caret ^ character .
When the test services report success Greenkeeper will silently delete the branch again, because no action needs to be taken – everything is fine.

However, should the tests fail, Greenkeeper will create an issue to inform you about the problem immediately.

This way, you’ll never be surprised by a dependency breaking your code. As long as everything still works, Greenkeeper will stay out of your way, and as soon as something goes wrong, you’ll be the first to know.

-  "lodash": "^3.0.0"
+  "lodash": "^4.0.0"

In this example, the new version 4.0.0 is not included in the old ^3.0.0 range.
For version updates like these – let’s call them “out of range” updates – you’ll receive a pull request.

This means that you no longer need to check for new versions manually – Greenkeeper will keep you up to date automatically.

These pull requests not only serve as reminders to update: If you have solid tests and good coverage, and the pull requests passes those tests, you can very likely just merge it and release a new version of your software straight away :shipit:

To get a better idea of which ranges apply to which releases, check out the extremely useful semver calculator provided by npm.

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Good luck with your project and see you soon ✨

Your Greenkeeper bot 🌴

@mozfreddyb mozfreddyb merged commit d313f9a into master Mar 1, 2019
@greenkeeper greenkeeper bot deleted the greenkeeper/initial branch March 1, 2019 10:29
@XhmikosR
Copy link
Collaborator

XhmikosR commented Mar 1, 2019

@mozfreddyb err, did you actually make any code changes? Those deps were left on purpose. It's not a drop-in replacement.

@mozfreddyb
Copy link
Contributor

tests were green? 😕

@XhmikosR
Copy link
Collaborator

XhmikosR commented Mar 1, 2019

Did you actually run the server? Tests only tell half the truth. The server isn't tested.

Please revert this and don't use greenkeeper in this repo.

@XhmikosR
Copy link
Collaborator

XhmikosR commented Mar 1, 2019

> srihash.org@0.2.0 start-dev C:\Users\xmr\Desktop\srihash.org
> cross-env NODE_ENV=development node ./index.js "index.js"

C:\Users\xmr\Desktop\srihash.org\index.js:25
server.connection({
       ^

TypeError: server.connection is not a function
    at Object.<anonymous> (C:\Users\xmr\Desktop\srihash.org\index.js:25:8)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:743:3)

@mozfreddyb
Copy link
Contributor

would be nice not to have outdated dependencies though 🤷‍♂️

@XhmikosR
Copy link
Collaborator

XhmikosR commented Mar 1, 2019

Yeah, sure, but this is proven to be a bad solution. I suggest that greenkeeper is removed completely from this repo and #225 is reverted.

One needs to go through the Hapi changes in order to see the API changes. That's why I said what I said here... #212 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants