Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Replace url.parse with the URL constructor. #253

Merged
merged 1 commit into from Apr 9, 2019
Merged

Replace url.parse with the URL constructor. #253

merged 1 commit into from Apr 9, 2019

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Apr 8, 2019 •
edited

Closes #231, fixes #215

I hope we don't miss any cases in our tests, otherwise everything seems to work :)

BTW when we switch to Node.js 10, we can drop the url requires since it's built-in.

@XhmikosR XhmikosR requested a review from mozfreddyb April 8, 2019 16:22
mozfreddyb
mozfreddyb approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mozfreddyb mozfreddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@mozfreddyb mozfreddyb merged commit 483e080 into master Apr 9, 2019
@XhmikosR XhmikosR deleted the xmr-url branch April 9, 2019 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mozfreddyb mozfreddyb mozfreddyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace url.parse with url.URL constructor
2 participants
@XhmikosR @mozfreddyb