trigger warning when browser dependent CDN was detected #518
Conversation
kota-yata
changed the title
|
Related to #514 |
|
Preview : https://kota-yata.github.io/srihash.org/ |
style.css
Outdated
| @@ -192,6 +192,14 @@ footer { | |||
| background-color: #ffb6c1; | |||
| } | |||
|
|
|||
| #warning { | |||
| background: #d5e47f; | |||
There was a problem hiding this comment.
Not a huge fan of the color, but I'm also not known for my good taste. Maybe something more like a warning-orange? :) It's OK to leave this if you feel strong.y
There was a problem hiding this comment.
I made it little more vivid in 8698f0d . Yellow looks better to me as a warning color than orange. Bright yellow is also better for accessibility.
There was a problem hiding this comment.
Thanks! I found another bug, though. :)
We'll get more warning boxes, if you keep hitting the "hash" button.
You need to either remove the box unconditionally (before the if (isBrowserDependent)...) or better, modify in-place if it already exists.
P.S: Thank you for working on the color.
|
Probably fixed in 3c8c796 |
|
thank you! |
Display warning if the pasted domain is matched with the constant list (
URL_LIST) incheckBrowserDepedency, which currently contains only fonts.googleapis.com.