Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Poor exception handling in client.rb #186

Closed
claudijd opened this issue Sep 16, 2016 · 0 comments
Closed

Poor exception handling in client.rb #186

claudijd opened this issue Sep 16, 2016 · 0 comments

Comments

@claudijd
Copy link
Contributor

Ran into this once, but it wasn't reproducible on the same client after the first attempt.

/Users/jclaudius/code/ssh_scan/lib/ssh_scan/client.rb:72:in `read': Connection reset by peer (Errno::ECONNRESET)
    from /Users/jclaudius/code/ssh_scan/lib/ssh_scan/client.rb:72:in `get_kex_result'
    from /Users/jclaudius/code/ssh_scan/lib/ssh_scan/scan_engine.rb:42:in `scan_target'
    from /Users/jclaudius/code/ssh_scan/lib/ssh_scan/scan_engine.rb:119:in `block (2 levels) in scan'

We should consider trapping this exception so it doesn't cause the scan to hard fail, but still report it. We might also consider at some point to retry some actions if they fail or cause an exception to increase our chances of success.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant